Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: pkg/analysis_server/test/completion_test.dart

Issue 2288223003: Don't perform final fields and top-level variables type propagation. (Closed)
Patch Set: Rewrite 'reuse' tests using 'inferredTypeSlot'. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/doc/tasks.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.completion.support; 5 library test.completion.support;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:collection'; 8 import 'dart:collection';
9 9
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 2832 matching lines...) Expand 10 before | Expand all | Expand 10 after
2843 test() { 2843 test() {
2844 topvar.!1top(); 2844 topvar.!1top();
2845 field.!2top(); 2845 field.!2top();
2846 } 2846 }
2847 }''', 2847 }''',
2848 <String>["1+top", "2+top"], 2848 <String>["1+top", "2+top"],
2849 failingTests: '12'); 2849 failingTests: '12');
2850 2850
2851 // test analysis of untyped fields and top-level vars 2851 // test analysis of untyped fields and top-level vars
2852 buildTests('test035', '''class Y {final x='hi';mth() {x.!1length;}}''', 2852 buildTests('test035', '''class Y {final x='hi';mth() {x.!1length;}}''',
2853 <String>["1+length"]); 2853 <String>["1+length"], failingTests: '1');
2854 2854
2855 // TODO(scheglov) decide what to do with Type for untyped field (not 2855 // TODO(scheglov) decide what to do with Type for untyped field (not
2856 // supported by the new store) 2856 // supported by the new store)
2857 // test analysis of untyped fields and top-level vars 2857 // test analysis of untyped fields and top-level vars
2858 buildTests( 2858 buildTests(
2859 'test036', 2859 'test036',
2860 ''' 2860 '''
2861 class A1 { 2861 class A1 {
2862 var field; 2862 var field;
2863 A1() : field = 0; 2863 A1() : field = 0;
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
2991 } else { 2991 } else {
2992 ++expectedPassCount; 2992 ++expectedPassCount;
2993 tester(testName, () { 2993 tester(testName, () {
2994 CompletionTestCase test = new CompletionTestCase(); 2994 CompletionTestCase test = new CompletionTestCase();
2995 return test.runTest(spec, extraFiles); 2995 return test.runTest(spec, extraFiles);
2996 }); 2996 });
2997 } 2997 }
2998 } 2998 }
2999 } 2999 }
3000 } 3000 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/doc/tasks.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698