Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 2288223003: Don't perform final fields and top-level variables type propagation. (Closed)
Patch Set: Rewrite 'reuse' tests using 'inferredTypeSlot'. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analysis_server.src.status.get_handler; 5 library analysis_server.src.status.get_handler;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:io'; 9 import 'dart:io';
10 import 'dart:math'; 10 import 'dart:math';
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 return unit; 479 return unit;
480 } 480 }
481 unit = entry.getValue(RESOLVED_UNIT11); 481 unit = entry.getValue(RESOLVED_UNIT11);
482 if (unit != null) { 482 if (unit != null) {
483 return unit; 483 return unit;
484 } 484 }
485 unit = entry.getValue(RESOLVED_UNIT12); 485 unit = entry.getValue(RESOLVED_UNIT12);
486 if (unit != null) { 486 if (unit != null) {
487 return unit; 487 return unit;
488 } 488 }
489 unit = entry.getValue(RESOLVED_UNIT13);
490 if (unit != null) {
491 return unit;
492 }
493 return entry.getValue(RESOLVED_UNIT); 489 return entry.getValue(RESOLVED_UNIT);
494 } 490 }
495 491
496 /** 492 /**
497 * Return a list of the result descriptors whose state should be displayed for 493 * Return a list of the result descriptors whose state should be displayed for
498 * the given cache [entry]. 494 * the given cache [entry].
499 */ 495 */
500 List<ResultDescriptor> _getExpectedResults(CacheEntry entry) { 496 List<ResultDescriptor> _getExpectedResults(CacheEntry entry) {
501 AnalysisTarget target = entry.target; 497 AnalysisTarget target = entry.target;
502 Set<ResultDescriptor> results = entry.nonInvalidResults.toSet(); 498 Set<ResultDescriptor> results = entry.nonInvalidResults.toSet();
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 results.add(RESOLVED_UNIT3); 551 results.add(RESOLVED_UNIT3);
556 results.add(RESOLVED_UNIT4); 552 results.add(RESOLVED_UNIT4);
557 results.add(RESOLVED_UNIT5); 553 results.add(RESOLVED_UNIT5);
558 results.add(RESOLVED_UNIT6); 554 results.add(RESOLVED_UNIT6);
559 results.add(RESOLVED_UNIT7); 555 results.add(RESOLVED_UNIT7);
560 results.add(RESOLVED_UNIT8); 556 results.add(RESOLVED_UNIT8);
561 results.add(RESOLVED_UNIT9); 557 results.add(RESOLVED_UNIT9);
562 results.add(RESOLVED_UNIT10); 558 results.add(RESOLVED_UNIT10);
563 results.add(RESOLVED_UNIT11); 559 results.add(RESOLVED_UNIT11);
564 results.add(RESOLVED_UNIT12); 560 results.add(RESOLVED_UNIT12);
565 results.add(RESOLVED_UNIT13);
566 results.add(RESOLVED_UNIT); 561 results.add(RESOLVED_UNIT);
567 results.add(STRONG_MODE_ERRORS); 562 results.add(STRONG_MODE_ERRORS);
568 results.add(USED_IMPORTED_ELEMENTS); 563 results.add(USED_IMPORTED_ELEMENTS);
569 results.add(USED_LOCAL_ELEMENTS); 564 results.add(USED_LOCAL_ELEMENTS);
570 results.add(VARIABLE_REFERENCE_ERRORS); 565 results.add(VARIABLE_REFERENCE_ERRORS);
571 results.add(VERIFY_ERRORS); 566 results.add(VERIFY_ERRORS);
572 } else if (target is ConstantEvaluationTarget) { 567 } else if (target is ConstantEvaluationTarget) {
573 results.add(CONSTANT_DEPENDENCIES); 568 results.add(CONSTANT_DEPENDENCIES);
574 results.add(CONSTANT_VALUE); 569 results.add(CONSTANT_VALUE);
575 if (target is VariableElement) { 570 if (target is VariableElement) {
(...skipping 2166 matching lines...) Expand 10 before | Expand all | Expand 10 after
2742 */ 2737 */
2743 static String makeLink( 2738 static String makeLink(
2744 String path, Map<String, String> params, String innerHtml, 2739 String path, Map<String, String> params, String innerHtml,
2745 [bool hasError = false]) { 2740 [bool hasError = false]) {
2746 Uri uri = new Uri(path: path, queryParameters: params); 2741 Uri uri = new Uri(path: path, queryParameters: params);
2747 String href = HTML_ESCAPE.convert(uri.toString()); 2742 String href = HTML_ESCAPE.convert(uri.toString());
2748 String classAttribute = hasError ? ' class="error"' : ''; 2743 String classAttribute = hasError ? ' class="error"' : '';
2749 return '<a href="$href"$classAttribute>$innerHtml</a>'; 2744 return '<a href="$href"$classAttribute>$innerHtml</a>';
2750 } 2745 }
2751 } 2746 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698