Remove STLDeleteContainerPairFirstPointers from AutofillDownloadManager

Remove STLDeleteContainerPairFirstPointers from AutofillDownloadManager

BUG=555865
Committed: https://crrev.com/0795e5640c5fde7e1e83b3797f6a474a84065ea0
Cr-Commit-Position: refs/heads/master@{#415019}

[vabr (Chromium), 2016-08-29 09:44:21]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 09:44:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 10:33:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 10:33:40]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-08-29 10:38:28]

vabr@chromium.org changed reviewers:
+ avi@chromium.org

[vabr (Chromium), 2016-08-29 10:38:29]

Hi Avi,

As an autofill OWNER, I follow up on your
https://groups.google.com/a/chromium.org/d/msg/cxx/xJpM3J_gpZY/IRgI8KZ9AgAJ.
Could you please review this?

Thanks!
Vaclav

[Avi (use Gerrit), 2016-08-29 16:05:32]

Looks good. I'm not a huge fan of std::pair, with ->first->second->second, etc,
but it's probably the simplest way to go here.

LGTM! Thanks!

[vabr (Chromium), 2016-08-29 16:15:06]

On 2016/08/29 16:05:32, Avi wrote:
> Looks good. I'm not a huge fan of std::pair, with ->first->second->second,
etc,
> but it's probably the simplest way to go here.
> 
> LGTM! Thanks!

I agree that the first->second->second looked ludicrous, but also that there
does not seem to be more other options. And it seems better than the mix of
manual deleting and the call in destructor.

Based on your approval, sending to the CQ now.

Cheers,
Vaclav

[vabr (Chromium), 2016-08-29 16:15:22]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:16:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 16:55:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-29 16:57:18]

Description was changed from

==========
Remove STLDeleteContainerPairFirstPointers from AutofillDownloadManager

BUG=555865
==========

to

==========
Remove STLDeleteContainerPairFirstPointers from AutofillDownloadManager

BUG=555865

Committed: https://crrev.com/0795e5640c5fde7e1e83b3797f6a474a84065ea0
Cr-Commit-Position: refs/heads/master@{#415019}
==========

[commit-bot: I haz the power, 2016-08-29 16:57:18]

Patchset 1 (id:??) landed as
https://crrev.com/0795e5640c5fde7e1e83b3797f6a474a84065ea0
Cr-Commit-Position: refs/heads/master@{#415019}