Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2288103002: [sensors] Add GetDefaultConfiguration() to generic sensor mojo interface. (Closed)

Created:
4 years, 3 months ago by shalamov
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), Mikhail, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Add GetDefaultConfiguration() to generic sensor mojo interface. This patch adds 'GetDefaultConfiguration' method to the generic sensor interface. It is required in cases when client (e.g. blink bindings) doesn't know what configuration to use for sensor initialization or when configuration that is provided to the client is incomplete. BUG=606766 Committed: https://crrev.com/090f099c1736b17fd7c8b5ba9033d08466ebd723 Cr-Commit-Position: refs/heads/master@{#415261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M device/generic_sensor/platform_sensor.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/public/interfaces/sensor.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M device/generic_sensor/sensor_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/generic_sensor/sensor_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
shalamov
PTAL
4 years, 3 months ago (2016-08-29 08:18:06 UTC) #2
Tom Sepez
mojom lgtm
4 years, 3 months ago (2016-08-29 16:34:40 UTC) #3
Reilly Grant (use Gerrit)
lgtm
4 years, 3 months ago (2016-08-29 18:22:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288103002/1
4 years, 3 months ago (2016-08-30 09:08:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:55:02 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:57:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/090f099c1736b17fd7c8b5ba9033d08466ebd723
Cr-Commit-Position: refs/heads/master@{#415261}

Powered by Google App Engine
This is Rietveld 408576698