Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2288093002:
Activate Skia SFNT filter, avoid Type 1 fonts (Closed)
DescriptionActivate Skia SFNT filter, avoid Type 1 fonts
https://codereview.chromium.org/2280053002 adds the possibility to
filter for only SFNT fonts in Skia on Linux, avoiding Type 1 font
files, conditional on the define
SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS.
This CL activates the filter in Chrome by defining this value.
BUG=632142
Committed: https://crrev.com/7834a17f1cc0d8e187531eeade45ebcb391b1308
Cr-Commit-Position: refs/heads/master@{#417282}
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Activate Skia SFNT filter, avoid Type 1 fonts https://codereview.chromium.org/2280053002 adds the possibility to filter for only SFNT fonts on Linux, avoiding Type 1 font files, conditional on the define SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS. This CL activates the filter in Chrome by defining this value. BUG=632142 ========== to ========== Activate Skia SFNT filter, avoid Type 1 fonts https://codereview.chromium.org/2280053002 adds the possibility to filter for only SFNT fonts in Skia on Linux, avoiding Type 1 font files, conditional on the define SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS. This CL activates the filter in Chrome by defining this value. BUG=632142 ==========
drott@chromium.org changed reviewers: + bungeman@chromium.org, fmalita@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL, now that the preparatory CL [1] that fixed the test cases has landed. [1] https://codereview.chromium.org/2302313002
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
drott@chromium.org changed reviewers: + reed@chromium.org, thakis@chromium.org, tomhudson@chromium.org
Based on comments in the linked issue, config change LGTM.
The CQ bit was checked by drott@chromium.org
On 2016/09/08 at 14:07:48, fmalita wrote: > Based on comments in the linked issue, config change LGTM. Thanks for the review.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Activate Skia SFNT filter, avoid Type 1 fonts https://codereview.chromium.org/2280053002 adds the possibility to filter for only SFNT fonts in Skia on Linux, avoiding Type 1 font files, conditional on the define SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS. This CL activates the filter in Chrome by defining this value. BUG=632142 ========== to ========== Activate Skia SFNT filter, avoid Type 1 fonts https://codereview.chromium.org/2280053002 adds the possibility to filter for only SFNT fonts in Skia on Linux, avoiding Type 1 font files, conditional on the define SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS. This CL activates the filter in Chrome by defining this value. BUG=632142 Committed: https://crrev.com/7834a17f1cc0d8e187531eeade45ebcb391b1308 Cr-Commit-Position: refs/heads/master@{#417282} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7834a17f1cc0d8e187531eeade45ebcb391b1308 Cr-Commit-Position: refs/heads/master@{#417282} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
