Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2288083002:
Call SelectionController().sendContextMenuEvent() with up-to-date layout tree (Closed)
|
Created:
4 years, 3 months ago by yosin_UTC9 Modified:
4 years, 3 months ago Reviewers:
tkent CC:
blink-reviews, chromium-reviews, dtapuska+blinkwatch_chromium.org, nzolghadr+blinkwatch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCall SelectionController().sendContextMenuEvent() with up-to-date layout tree
BUG=641403
TEST=run_webkit_unit_tests --gtest_filter=ventHandlerTest.sendContextMenuEventWithHover
Committed: https://crrev.com/e7e52616f252b5dca01400374e1076ab683c9620
Cr-Commit-Position: refs/heads/master@{#415052}
Patch Set 1 : 2016-08-29T15:45:26 #
Total comments: 2
Patch Set 2 : 2016-08-29T17:10:41 #
Messages
Total messages: 26 (16 generated)
Description was changed from ========== 2016-08-29T15:45:26 BUG= ========== to ========== Call SelectionController().sendContextMenuEvent() with up-to-date layout tree BUG=641403 TEST=run_webkit_unit_tests --gtest_filter= ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Call SelectionController().sendContextMenuEvent() with up-to-date layout tree BUG=641403 TEST=run_webkit_unit_tests --gtest_filter= ========== to ========== Call SelectionController().sendContextMenuEvent() with up-to-date layout tree BUG=641403 TEST=run_webkit_unit_tests --gtest_filter=ventHandlerTest.sendContextMenuEventWithHover ==========
yosin@chromium.org changed reviewers: + tkent@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm https://codereview.chromium.org/2288083002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2288083002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/input/EventHandler.cpp:2044: // Since // |Document::prepareMouseEvent()| modifies layout tree for setting Is the second '//' unnecessary?
The CQ bit was checked by yosin@chromium.org
The CQ bit was unchecked by yosin@chromium.org
Thanks for reviewing! https://codereview.chromium.org/2288083002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2288083002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/input/EventHandler.cpp:2044: // Since // |Document::prepareMouseEvent()| modifies layout tree for setting On 2016/08/29 at 08:01:21, tkent wrote: > Is the second '//' unnecessary? Done. No, removed.
The CQ bit was checked by yosin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2288083002/#ps20001 (title: "2016-08-29T17:10:41")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Call SelectionController().sendContextMenuEvent() with up-to-date layout tree BUG=641403 TEST=run_webkit_unit_tests --gtest_filter=ventHandlerTest.sendContextMenuEventWithHover ========== to ========== Call SelectionController().sendContextMenuEvent() with up-to-date layout tree BUG=641403 TEST=run_webkit_unit_tests --gtest_filter=ventHandlerTest.sendContextMenuEventWithHover Committed: https://crrev.com/e7e52616f252b5dca01400374e1076ab683c9620 Cr-Commit-Position: refs/heads/master@{#415052} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e7e52616f252b5dca01400374e1076ab683c9620 Cr-Commit-Position: refs/heads/master@{#415052} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
