Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2288053002: Prevent thread assertion for HTC mail apk (Closed)

Created:
4 years, 3 months ago by Changwan Ryu
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Prevent thread assertion for HTC mail apk HTC's mail apk calls evaluateJavaScript() inside InputConnection#setComposingText(). This is problematic with ImeThread feature since InputConnection methods are now running on its own thread (IME thread). This causes a thread check assertion in Android's framework (android.webkit.WebView). As a workaround, we set sEnforceThreadChecking to false immediately after it was set in WebView's constructor. HTC is actively fixing their apk to avoid this crash, but as a last resort, this workaround will help avoid such a crash. BUG=636717, 622151 Review-Url: https://codereview.chromium.org/2243753002 Cr-Commit-Position: refs/heads/master@{#414717} (cherry picked from commit f99c4ade4b10c24a59b7bf34de4d7509e7ca8708) Committed: https://chromium.googlesource.com/chromium/src/+/e1d506220fb8a5993f7025c0e91aafb502bb7b6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 6 chunks +38 lines, -4 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 5 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 3 months ago (2016-08-29 02:44:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1d506220fb8a5993f7025c0e91aafb502bb7b6d.

Powered by Google App Engine
This is Rietveld 408576698