Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2288033002: MD History: Fix focus highlight on 'Sign in to Chrome' button (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix focus highlight on 'Sign in to Chrome' button This changes the button to use the shared action-button style, which makes the focus styling consistent with other material WebUIs. BUG=640908 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1615aabb99d99095e997bc6b6cd8c15caa7fdd2f Cr-Commit-Position: refs/heads/master@{#416482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tsergeant
PTAL. There's an issue where at certain screen widths, changing font-weight to bold on focus ...
4 years, 3 months ago (2016-08-29 01:10:09 UTC) #3
calamity
lgtm
4 years, 3 months ago (2016-09-02 06:06:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288033002/1
4 years, 3 months ago (2016-09-04 23:43:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 00:48:17 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 00:50:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1615aabb99d99095e997bc6b6cd8c15caa7fdd2f
Cr-Commit-Position: refs/heads/master@{#416482}

Powered by Google App Engine
This is Rietveld 408576698