base/mac/mac_util_unittest.mm - Issue 2288003002: Delete IsAtLeastOS10_9() and IsAtMostOS10_9()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/mac/mac_util_unittest.mm

Issue 2288003002: Delete IsAtLeastOS10_9() and IsAtMostOS10_9() (Closed)

Patch Set: Rebase, cancel the more confusing changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/mac/mac_util_unittest.mm

diff --git a/base/mac/mac_util_unittest.mm b/base/mac/mac_util_unittest.mm

index cf567c684cb520528d67ddfcebc34f73dc23b5c9..c8e8401413e0e4b4a234c659fa286361b9982def 100644

--- a/base/mac/mac_util_unittest.mm

+++ b/base/mac/mac_util_unittest.mm

@@ -147,8 +147,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {

if (major == 10) {

if (minor == 9) {

EXPECT_TRUE(IsOS10_9());

- EXPECT_TRUE(IsAtMostOS10_9());

- EXPECT_TRUE(IsAtLeastOS10_9());

EXPECT_FALSE(IsOS10_10());

EXPECT_TRUE(IsAtMostOS10_10());

EXPECT_FALSE(IsAtLeastOS10_10());

@@ -161,8 +159,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {

EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());

} else if (minor == 10) {

EXPECT_FALSE(IsOS10_9());

- EXPECT_FALSE(IsAtMostOS10_9());

- EXPECT_TRUE(IsAtLeastOS10_9());

EXPECT_TRUE(IsOS10_10());

EXPECT_TRUE(IsAtMostOS10_10());

EXPECT_TRUE(IsAtLeastOS10_10());

@@ -175,8 +171,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {

EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());

} else if (minor == 11) {

EXPECT_FALSE(IsOS10_9());

- EXPECT_FALSE(IsAtMostOS10_9());

- EXPECT_TRUE(IsAtLeastOS10_9());

EXPECT_FALSE(IsOS10_10());

EXPECT_FALSE(IsAtMostOS10_10());

EXPECT_TRUE(IsAtLeastOS10_10());

@@ -189,8 +183,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {

EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());

} else if (minor == 12) {

EXPECT_FALSE(IsOS10_9());

- EXPECT_FALSE(IsAtMostOS10_9());

- EXPECT_TRUE(IsAtLeastOS10_9());

EXPECT_FALSE(IsOS10_10());

EXPECT_FALSE(IsAtMostOS10_10());

EXPECT_TRUE(IsAtLeastOS10_10());

« no previous file with comments | « base/mac/mac_util.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('j') | no next file with comments »