Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: base/mac/mac_util_unittest.mm

Issue 2288003002: Delete IsAtLeastOS10_9() and IsAtMostOS10_9() (Closed)
Patch Set: Clean up a duplicate check, delete a stray ! Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/sys_info_mac.mm » ('j') | base/sys_info_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/mac/mac_util_unittest.mm
diff --git a/base/mac/mac_util_unittest.mm b/base/mac/mac_util_unittest.mm
index cf567c684cb520528d67ddfcebc34f73dc23b5c9..cd99f47f9c6bf2fcd77d22d2cbd8c500e03b7bba 100644
--- a/base/mac/mac_util_unittest.mm
+++ b/base/mac/mac_util_unittest.mm
@@ -146,9 +146,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {
if (major == 10) {
if (minor == 9) {
- EXPECT_TRUE(IsOS10_9());
- EXPECT_TRUE(IsAtMostOS10_9());
- EXPECT_TRUE(IsAtLeastOS10_9());
EXPECT_FALSE(IsOS10_10());
EXPECT_TRUE(IsAtMostOS10_10());
EXPECT_FALSE(IsAtLeastOS10_10());
@@ -160,9 +157,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {
EXPECT_TRUE(IsAtMostOS10_12());
EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
} else if (minor == 10) {
- EXPECT_FALSE(IsOS10_9());
- EXPECT_FALSE(IsAtMostOS10_9());
- EXPECT_TRUE(IsAtLeastOS10_9());
EXPECT_TRUE(IsOS10_10());
EXPECT_TRUE(IsAtMostOS10_10());
EXPECT_TRUE(IsAtLeastOS10_10());
@@ -174,9 +168,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {
EXPECT_TRUE(IsAtMostOS10_12());
EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
} else if (minor == 11) {
- EXPECT_FALSE(IsOS10_9());
- EXPECT_FALSE(IsAtMostOS10_9());
- EXPECT_TRUE(IsAtLeastOS10_9());
EXPECT_FALSE(IsOS10_10());
EXPECT_FALSE(IsAtMostOS10_10());
EXPECT_TRUE(IsAtLeastOS10_10());
@@ -188,9 +179,6 @@ TEST_F(MacUtilTest, IsOSEllipsis) {
EXPECT_TRUE(IsAtMostOS10_12());
EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
} else if (minor == 12) {
- EXPECT_FALSE(IsOS10_9());
- EXPECT_FALSE(IsAtMostOS10_9());
- EXPECT_TRUE(IsAtLeastOS10_9());
EXPECT_FALSE(IsOS10_10());
EXPECT_FALSE(IsAtMostOS10_10());
EXPECT_TRUE(IsAtLeastOS10_10());
« no previous file with comments | « no previous file | base/sys_info_mac.mm » ('j') | base/sys_info_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698