Source/core/dom/ContainerNode.cpp - Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add missing test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/XMLSerializer-doctype2.html ('K') | « LayoutTests/fast/events/dispatch-event-no-document-expected.txt ('k') | Source/core/dom/DOMImplementation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index 1b26b71ed4092b7f264fd8962e5148ff451b7108..1aaf4c27397f0bd0a7be041057e9bffbd2b8d777 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -173,10 +173,6 @@ static inline bool checkAcceptChild(ContainerNode* newParent, Node* newChild, No

return false;

}

- if (newChild->inDocument() && newChild->isDocumentTypeNode()) {

- es.throwDOMException(HierarchyRequestError);

- return false;

- }

if (containsConsideringHostElements(newChild, newParent)) {

es.throwDOMException(HierarchyRequestError);

return false;