[NoStatePrefetch] Add UMA histogram to count prefetch requests

chrome/browser/prerender/prerender_histograms.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_histograms.h"
 
 #include <string>
 
 #include "base/format_macros.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/predictors/autocomplete_action_predictor.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_util.h"
 
 using predictors::AutocompleteActionPredictor;
 
 namespace prerender {
 
 namespace {
 
+// This enum is used to define the buckets for the
+// "Prerender.NoStatePrefetchResourceCount" histogram family.
+// Hence, existing enumerated constants should never be deleted or reordered,
+// and new constants should only be appended at the end of the enumeration.
+enum NoStatePrefetchResourceType {
+  kMainResourceCacheable = 0,

[pasko, 2016/08/30 13:41:04]

I think chromium style prefers MACRO_STYLE constants, at least it is so in
chrome/browser/prerender/, let's keep it this way for consistency.

Also, c++11 promotes using 'scoped enums' aka 'enum class Foo {...};'

[droger, 2016/08/30 14:31:41]

changed the naming style, however I need these to be convertible to int, so I
didn't use the enum class.

+  kMainResourceNoStore = 1,
+  kSubResourceCacheable = 2,
+  kSubResourceNoStore = 3,
+
+  kNoStatePrefetchResourceTypeCount  // Must be the last.
+};
+
 // Time window for which we will record windowed PLTs from the last observed
 // link rel=prefetch tag. This is not intended to be the same as the prerender
 // ttl, it's just intended to be a window during which a prerender has likely
 // affected performance.
 const int kWindowDurationSeconds = 30;
 
 std::string ComposeHistogramName(const std::string& prefix_type,
                                  const std::string& name) {
   if (prefix_type.empty())
     return std::string("Prerender.") + name;
@@ skipping 344 matching lines @@
             name, prerender_bytes, kHistogramMin, kHistogramMax, kBucketCount));
   } else {
     PREFIXED_HISTOGRAM(
         "NetworkBytesWasted",
         origin,
         UMA_HISTOGRAM_CUSTOM_COUNTS(
             name, prerender_bytes, kHistogramMin, kHistogramMax, kBucketCount));
   }
 }
 
+void PrerenderHistograms::RecordResourcePrefetch(Origin origin,
+                                                 bool is_main_resource,
+                                                 bool is_no_store) {
+  NoStatePrefetchResourceType type =
+      is_main_resource
+          ? (is_no_store ? kMainResourceNoStore : kMainResourceCacheable)
+          : (is_no_store ? kSubResourceNoStore : kSubResourceCacheable);
+  DCHECK_LT(type, kNoStatePrefetchResourceTypeCount);
+
+  std::string histogram_name =
+      GetHistogramName(origin, IsOriginWash(), "NoStatePrefetchResourceCount");
+
+  // Unrolls UMA_HISTOGRAM_ENUMERATION, required to support dynamic histogram

[pasko, 2016/08/30 13:41:04]

Would it be possible to DCHECK_CURRENTLY_ON(BrowserThread::UI) here? AFAIR
FactoryGet is not thread safe.

[droger, 2016/08/30 14:31:41]

Done (using a thread checker).

+  // name.
+  base::HistogramBase* histogram_pointer = base::LinearHistogram::FactoryGet(
+      histogram_name, 1, kNoStatePrefetchResourceTypeCount,
+      kNoStatePrefetchResourceTypeCount + 1,
+      base::HistogramBase::kUmaTargetedHistogramFlag);
+  histogram_pointer->Add(type);
+}
+
 bool PrerenderHistograms::IsOriginWash() const {
   if (!WithinWindow())
     return false;
   return origin_wash_;
 }
 
 }  // namespace prerender