Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2287973002: Tidy up some loops in SMILTimeContainer::updateAnimations (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up some loops in SMILTimeContainer::updateAnimations Use for-range style loops and get rid of the local 'size' variable. Also move the sort() call down after the early-out when there are no animations to apply. BUG=641437 Committed: https://crrev.com/887b2bd70548734daaa7f1c13ed696612fc095d2 Cr-Commit-Position: refs/heads/master@{#415165}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 2 chunks +12 lines, -14 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
fs
4 years, 3 months ago (2016-08-28 17:24:35 UTC) #6
pdr.
LGTM https://codereview.chromium.org/2287973002/diff/1/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp File third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp (right): https://codereview.chromium.org/2287973002/diff/1/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp#newcode522 third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp:522: if (timedElement->isConnected() && timedElement->isSVGDiscardElement()) { Forever reminded of ...
4 years, 3 months ago (2016-08-29 00:47:03 UTC) #7
fs
https://codereview.chromium.org/2287973002/diff/1/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp File third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp (right): https://codereview.chromium.org/2287973002/diff/1/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp#newcode522 third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp:522: if (timedElement->isConnected() && timedElement->isSVGDiscardElement()) { On 2016/08/29 at 00:47:03, ...
4 years, 3 months ago (2016-08-29 08:14:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287973002/1
4 years, 3 months ago (2016-08-29 20:23:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:36:25 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:38:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/887b2bd70548734daaa7f1c13ed696612fc095d2
Cr-Commit-Position: refs/heads/master@{#415165}

Powered by Google App Engine
This is Rietveld 408576698