|
|
Created:
4 years, 3 months ago by Azure Wei Modified:
4 years, 3 months ago Reviewers:
James Cook CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBased on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button.
BUG=641300
TEST=Verified on local build.
Committed: https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96
Cr-Commit-Position: refs/heads/master@{#415176}
Patch Set 1 #Patch Set 2 #Patch Set 3 #
Total comments: 2
Patch Set 4 : Add class comments. #
Messages
Total messages: 22 (16 generated)
Description was changed from ========== Update the UI of setting button on IME menu. BUG=641300 TEST=Verified on local build. ========== to ========== Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG=641300 TEST=Verified on local build. ==========
azurewei@chromium.org changed reviewers: + jamescook@chromium.org
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
The CQ bit was unchecked by azurewei@chromium.org
The CQ bit was checked by azurewei@chromium.org
The CQ bit was unchecked by azurewei@chromium.org
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please review this cl. Thanks!
LGTM https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chrom... File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right): https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chrom... ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:81: class ImeButtonsView : public views::View, nit: class comment please
https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chrom... File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right): https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chrom... ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:81: class ImeButtonsView : public views::View, On 2016/08/29 16:12:02, James Cook wrote: > nit: class comment please Done.
The CQ bit was checked by azurewei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org Link to the patchset: https://codereview.chromium.org/2287953002/#ps60001 (title: "Add class comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG=641300 TEST=Verified on local build. ========== to ========== Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG=641300 TEST=Verified on local build. ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG=641300 TEST=Verified on local build. ========== to ========== Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG=641300 TEST=Verified on local build. Committed: https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96 Cr-Commit-Position: refs/heads/master@{#415176} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96 Cr-Commit-Position: refs/heads/master@{#415176} |