Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2287953002: Update the UI of setting button on IME menu. (Closed)

Created:
4 years, 3 months ago by Azure Wei
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Based on UI reviewer's comments, the setting button on opt-in IME menu should be update as only text when there's only one button. BUG=641300 TEST=Verified on local build. Committed: https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96 Cr-Commit-Position: refs/heads/master@{#415176}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 : Add class comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -74 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 1 2 3 3 chunks +71 lines, -71 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Azure Wei
Please review this cl. Thanks!
4 years, 3 months ago (2016-08-28 11:59:19 UTC) #13
James Cook
LGTM https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right): https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc#newcode81 ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:81: class ImeButtonsView : public views::View, nit: class comment ...
4 years, 3 months ago (2016-08-29 16:12:02 UTC) #14
Azure Wei
https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right): https://codereview.chromium.org/2287953002/diff/40001/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc#newcode81 ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:81: class ImeButtonsView : public views::View, On 2016/08/29 16:12:02, James ...
4 years, 3 months ago (2016-08-29 23:59:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287953002/60001
4 years, 3 months ago (2016-08-30 02:07:09 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 05:45:55 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:47:41 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/acbd0c3b500bdd3de1dff36e2d5f771f1413ca96
Cr-Commit-Position: refs/heads/master@{#415176}

Powered by Google App Engine
This is Rietveld 408576698