Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2287933002: Revert of Don't mark navigations as in-page when DSNs are mismatched. (Closed)

Created:
4 years, 3 months ago by nasko
Modified:
4 years, 3 months ago
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't mark navigations as in-page when DSNs are mismatched. (patchset #1 id:1 of https://codereview.chromium.org/2253233002/ ) Reason for revert: Reverting post branch point for another attempt at diagnosing the remaining cases where origin and URL are mismatched. Original issue's description: > Don't mark navigations as in-page when DSNs are mismatched. > > This CL implements a TODO by creis@ to ensure that the renderer doesn't > classify history navigations as in-page if the document sequence number > of the current document and the one being navigated to are mismatched. > > BUG=628677, 630103 > > Committed: https://crrev.com/cf477b509f7a5a3409ac1f2aecf9513d7c82c5b3 > Cr-Commit-Position: refs/heads/master@{#413353} TBR=avi@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628677, 630103 Committed: https://crrev.com/18ae7a912d650b63b480186c574f672e3ed5d47f Cr-Commit-Position: refs/heads/master@{#414955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nasko
Created Revert of Don't mark navigations as in-page when DSNs are mismatched.
4 years, 3 months ago (2016-08-28 02:18:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287933002/1
4 years, 3 months ago (2016-08-28 02:18:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-28 03:20:55 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-28 03:25:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18ae7a912d650b63b480186c574f672e3ed5d47f
Cr-Commit-Position: refs/heads/master@{#414955}

Powered by Google App Engine
This is Rietveld 408576698