Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2287913002:
Add hash to net-internals URL to launch net diagnostics extension
|
Created:
4 years, 3 months ago by yyefet Modified:
4 years, 3 months ago Reviewers:
eroman CC:
chromium-reviews, eroman, arv+watch_chromium.org, Randy Smith (Not in Mondays), xunjieli Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd hash to net-internals URL to launch net diagnostics extension
This CL adds a new hash to the chrome://net-internals url that
launches the built in connectivity diagnostics extension on
ChromeOS devices.
The new hash is: chrome://net-internals/#diagnostics
When visited in the browser, it will launch:
chrome-extension://idddmepepmjcgiedknnmlbadcokidhoa/index.html
BUG=641702
R=mmenke@chromium.org
TEST=Build chromium for chromeos and enter new url with hash
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Patch Set 1 #
Messages
Total messages: 16 (4 generated)
Description was changed from ========== Add hash to net-internals URL to launch net diagnostics extension This CL adds a new hash to the chrome://net-internals url that launches the built in connectivity diagnostics extension on ChromeOS devices. The new hash is: chrome://net-internals/#diagnostics When visited in the browser, it will launch: chrome-extension://idddmepepmjcgiedknnmlbadcokidhoa/index.html BUG=641702 R=mmenke@chromium.org TEST=Build chromium for chromeos and enter new url with hash ========== to ========== Add hash to net-internals URL to launch net diagnostics extension This CL adds a new hash to the chrome://net-internals url that launches the built in connectivity diagnostics extension on ChromeOS devices. The new hash is: chrome://net-internals/#diagnostics When visited in the browser, it will launch: chrome-extension://idddmepepmjcgiedknnmlbadcokidhoa/index.html BUG=641702 R=mmenke@chromium.org TEST=Build chromium for chromeos and enter new url with hash CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
We're working towards removing net-internals from Chrome. I don't think we want to add more internal hooks to it.
On 2016/08/27 20:08:54, mmenke wrote: > We're working towards removing net-internals from Chrome. I don't think we want > to add more internal hooks to it. Interesting.. I was not aware of that. This tool is heavily used by enterprise support... will there be a replacement or is it just moving somewhere else? Is there an ETA for the removal?
On 2016/08/27 20:16:34, yyefet wrote: > On 2016/08/27 20:08:54, mmenke wrote: > > We're working towards removing net-internals from Chrome. I don't think we > want > > to add more internal hooks to it. > > Interesting.. I was not aware of that. > This tool is heavily used by enterprise support... will there be a replacement > or is it just moving somewhere else? > Is there an ETA for the removal? Not currently, though we do have net-internals working as an external project outside of Chrome. For all the network stuff, the plan is to use about:net-export instead. We have no plans for the stuff not owned by the ChromeOS team. I've mentioned this before on bugs, like https://bugs.chromium.org/p/chromium/issues/detail?id=475772. Not sure if there's a filed bug about it.
On 2016/08/27 20:27:13, mmenke wrote: > On 2016/08/27 20:16:34, yyefet wrote: > > On 2016/08/27 20:08:54, mmenke wrote: > > > We're working towards removing net-internals from Chrome. I don't think we > > want > > > to add more internal hooks to it. > > > > Interesting.. I was not aware of that. > > This tool is heavily used by enterprise support... will there be a replacement > > or is it just moving somewhere else? > > Is there an ETA for the removal? > > Not currently, though we do have net-internals working as an external project > outside of Chrome. > > For all the network stuff, the plan is to use about:net-export instead. We have > no plans for the stuff not owned by the ChromeOS team. I've mentioned this > before on bugs, like > https://bugs.chromium.org/p/chromium/issues/detail?id=475772. Not sure if > there's a filed bug about it. Bug about it == bug about moving the ChromeOS stuff elsewhere - I actually seem to recall someone working on ChromeOS filing a bug about it in response to my comments a while back, but can't find the bug. May be misremembering, or may be lost in the noise.
On 2016/08/27 20:39:35, mmenke wrote: > On 2016/08/27 20:27:13, mmenke wrote: > > On 2016/08/27 20:16:34, yyefet wrote: > > > On 2016/08/27 20:08:54, mmenke wrote: > > > > We're working towards removing net-internals from Chrome. I don't think > we > > > want > > > > to add more internal hooks to it. > > > > > > Interesting.. I was not aware of that. > > > This tool is heavily used by enterprise support... will there be a > replacement > > > or is it just moving somewhere else? > > > Is there an ETA for the removal? > > > > Not currently, though we do have net-internals working as an external project > > outside of Chrome. > > > > For all the network stuff, the plan is to use about:net-export instead. We > have > > no plans for the stuff not owned by the ChromeOS team. I've mentioned this > > before on bugs, like > > https://bugs.chromium.org/p/chromium/issues/detail?id=475772. Not sure if > > there's a filed bug about it. > > Bug about it == bug about moving the ChromeOS stuff elsewhere - I actually seem > to recall someone working on ChromeOS filing a bug about it in response to my > comments a while back, but can't find the bug. May be misremembering, or may be > lost in the noise Ahh, I think this is the bug you are referencing: https://bugs.chromium.org/p/chromium/issues/detail?id=472699 Seems like only the logging part of net-internals for chromeos will be removed.. not the whole host (net-internals). The hook in this CL doesn't interact with the chromeos logging mechanism at all... (ie.: if chromeos logging gets removed, this will still function) All this hook does is launch a 'connectivity diagnostics' extension when the hash "#diagnostics" is added to the net-internals host (chrome://net-internals#diagnostics)
mmenke@chromium.org changed reviewers: + eroman@chromium.org
[+eroman, rdsmith, xunjieli] I'll defer to others on just what to do here. I had thought the plan was to completely remove net-internals.
On 2016/08/27 21:02:02, mmenke wrote: > [+eroman, rdsmith, xunjieli] I'll defer to others on just what to do here. I > had thought the plan was to completely remove net-internals. And just to add...If the plan is to completely remove about:net-internals, I don't think we should be adding dependencies on it now. If it's just to leave it a shell of its former self, then this is fine, though we presumably will also want to hand off ownership of it at some point, as the network stack team won't have much reason to maintain what's left.
UI-Review is ok with adding the hash for this piece unless all CrOS stuff gets moved elsewhere. snanda@ may know btw
UI-Review is ok with adding the hash for this piece unless all CrOS stuff gets moved elsewhere. snanda@ may know btw
Will comment on the bug.
Description was changed from ========== Add hash to net-internals URL to launch net diagnostics extension This CL adds a new hash to the chrome://net-internals url that launches the built in connectivity diagnostics extension on ChromeOS devices. The new hash is: chrome://net-internals/#diagnostics When visited in the browser, it will launch: chrome-extension://idddmepepmjcgiedknnmlbadcokidhoa/index.html BUG=641702 R=mmenke@chromium.org TEST=Build chromium for chromeos and enter new url with hash CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add hash to net-internals URL to launch net diagnostics extension This CL adds a new hash to the chrome://net-internals url that launches the built in connectivity diagnostics extension on ChromeOS devices. The new hash is: chrome://net-internals/#diagnostics When visited in the browser, it will launch: chrome-extension://idddmepepmjcgiedknnmlbadcokidhoa/index.html BUG=641702 R=mmenke@chromium.org TEST=Build chromium for chromeos and enter new url with hash CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
mmenke@chromium.org changed reviewers: - mmenke@chromium.org |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
