Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 22879002: Fix cros telemetry bustage. (Closed)

Created:
7 years, 4 months ago by achuithb
Modified:
7 years, 4 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, James Simonsen
Visibility:
Public.

Description

Fix cros telemetry bustage. Regression introduced by crrev.com/216268 Symptom is errors like: TypeError("argument of type 'NoneType' is not iterable",) BUG=270148 TEST=manual R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/chrome/cros_browser_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
achuithb
Please review, Tony and Dave.
7 years, 4 months ago (2013-08-12 17:03:36 UTC) #1
tonyg
lgtm
7 years, 4 months ago (2013-08-12 17:08:58 UTC) #2
achuithb
7 years, 4 months ago (2013-08-12 17:16:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r217026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698