Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2287833002: Revert of Move gyp-win-tool to the GN Windows toolchain. (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw, scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move gyp-win-tool to the GN Windows toolchain. (patchset #6 id:100001 of https://codereview.chromium.org/2287603003/ ) Reason for revert: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10319/steps/compile/logs/stdio Original issue's description: > Move gyp-win-tool to the GN Windows toolchain. > > Renames it tool_wrapper.py but otherwise keeps it unchanged from the original > https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py > > I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check. > > Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing. > > The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now. > > Committed: https://crrev.com/6afaa104b1fa8c6caee4e53b2e37142832ec9f9e > Cr-Commit-Position: refs/heads/master@{#414859} TBR=scottmg@chromium.org,dpranke@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9738e8297d39ff71bc772514066b5d7eadd4c4da Cr-Commit-Position: refs/heads/master@{#414880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -352 lines) Patch
M build/config/win/manifest.gni View 3 chunks +5 lines, -5 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +2 lines, -5 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 9 chunks +10 lines, -9 lines 0 comments Download
M build/toolchain/win/midl.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/toolchain/win/setup_toolchain.py View 2 chunks +36 lines, -7 lines 0 comments Download
D build/toolchain/win/tool_wrapper.py View 1 chunk +0 lines, -324 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jianli
Created Revert of Move gyp-win-tool to the GN Windows toolchain.
4 years, 3 months ago (2016-08-27 00:41:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287833002/1
4 years, 3 months ago (2016-08-27 00:42:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 00:43:02 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9738e8297d39ff71bc772514066b5d7eadd4c4da Cr-Commit-Position: refs/heads/master@{#414880}
4 years, 3 months ago (2016-08-27 00:46:35 UTC) #6
Dirk Pranke
4 years, 3 months ago (2016-08-27 15:11:35 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698