DescriptionRevert of Move gyp-win-tool to the GN Windows toolchain. (patchset #6 id:100001 of https://codereview.chromium.org/2287603003/ )
Reason for revert:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10319/steps/compile/logs/stdio
Original issue's description:
> Move gyp-win-tool to the GN Windows toolchain.
>
> Renames it tool_wrapper.py but otherwise keeps it unchanged from the original
> https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py
>
> I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check.
>
> Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing.
>
> The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now.
>
> Committed: https://crrev.com/6afaa104b1fa8c6caee4e53b2e37142832ec9f9e
> Cr-Commit-Position: refs/heads/master@{#414859}
TBR=scottmg@chromium.org,dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/9738e8297d39ff71bc772514066b5d7eadd4c4da
Cr-Commit-Position: refs/heads/master@{#414880}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|