 Chromium Code Reviews
 Chromium Code Reviews Issue 228783007:
  rAc: make requestAutocomplete() return a promise.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 228783007:
  rAc: make requestAutocomplete() return a promise.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/html/HTMLFormElement.h | 
| diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h | 
| index 86418c755d998b072827d7593f657360d50e6cff..f03008a8a8a1d84ccf9034e145be8bf4dabfb9a5 100644 | 
| --- a/Source/core/html/HTMLFormElement.h | 
| +++ b/Source/core/html/HTMLFormElement.h | 
| @@ -29,6 +29,7 @@ | 
| #include "core/html/forms/RadioButtonGroupScope.h" | 
| #include "core/loader/FormSubmission.h" | 
| #include "wtf/OwnPtr.h" | 
| +#include "wtf/RefPtr.h" | 
| #include "wtf/WeakPtr.h" | 
| namespace WTF{ | 
| @@ -37,12 +38,14 @@ class TextEncoding; | 
| namespace WebCore { | 
| +class AutocompleteRequest; | 
| class Event; | 
| class FormAssociatedElement; | 
| class FormData; | 
| class HTMLFormControlElement; | 
| class HTMLImageElement; | 
| class HTMLInputElement; | 
| +class ScriptPromise; | 
| class HTMLFormElement FINAL : public HTMLElement { | 
| public: | 
| @@ -103,7 +106,7 @@ public: | 
| AutocompleteResultErrorInvalid, | 
| }; | 
| - void requestAutocomplete(const Dictionary&); | 
| + ScriptPromise requestAutocomplete(const Dictionary&); | 
| void finishRequestAutocomplete(AutocompleteResult); | 
| DEFINE_ATTRIBUTE_EVENT_LISTENER(autocomplete); | 
| @@ -177,9 +180,11 @@ private: | 
| bool m_wasDemoted; | 
| + void doFinishRequestAutocomplete(AutocompleteResult, PassOwnPtr<AutocompleteRequest>); | 
| void requestAutocompleteTimerFired(Timer<HTMLFormElement>*); | 
| - WillBePersistentHeapVector<RefPtrWillBeMember<Event> > m_pendingAutocompleteEvents; | 
| + OwnPtr<AutocompleteRequest> m_pendingAutocompleteRequest; | 
| + WillBePersistentHeapVector<OwnPtrWillBeMember<AutocompleteRequest> > m_finishedAutocompleteRequests; | 
| 
tkent
2014/04/17 02:51:41
This should be |Vector<OwnPtr<AutocompleteRequest>
 
Dan Beam
2014/04/17 23:02:04
Done.
 | 
| Timer<HTMLFormElement> m_requestAutocompleteTimer; | 
| }; |