Issue 228783005: [ChromeOS] Don't set NO_NEW_PRIVS for ProcessProxy processes (e.g. Crosh) when in dev-mode.

Issue 228783005: [ChromeOS] Don't set NO_NEW_PRIVS for ProcessProxy processes (e.g. Crosh) when in dev-mode. (Closed)

Created:
6 years, 8 months ago by Robert Sesek

Modified:
6 years, 8 months ago

Reviewers:
DaveMoore, Daniel Erat, jln (very slow on Chromium)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, Kees Cook

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[ChromeOS] Don't set NO_NEW_PRIVS for ProcessProxy processes (e.g. Crosh) when in dev-mode. BUG=358713 TEST=Put system in dev mode, open Crosh, type `shell`, and run sudo. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263092

Patch Set 1 #

Patch Set 2 : Fix header #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/login/chrome_restart_request.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	chromeos/process_proxy/process_proxy.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Friendly ping. Let me know if you're not a good reviewer for this, Dave.

6 years, 8 months ago (2014-04-10 16:48:41 UTC) #2

jln (very slow on Chromium)

lgtm Dave: this only requires owner approval, thanks!

6 years, 8 months ago (2014-04-10 19:27:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/228783005/20001

6 years, 8 months ago (2014-04-10 20:24:36 UTC) #7

Message was sent while issue was closed.

Change committed as 263092

Expand Messages | Collapse Messages