Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 228783002: Moves knowledge of Profile out of FaviconHandler, into FaviconTabHelper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_3
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index ffa4c6017d2230e08db4b0670ea1fee003376444..c175b1e9b6c99f893fc65513fc0258305034d3aa 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -19,6 +19,7 @@
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
+class FaviconClient;
class FaviconDriver;
class FaviconHandlerDelegate;
class Profile;
@@ -85,6 +86,7 @@ class FaviconHandler {
};
FaviconHandler(Profile* profile,
+ FaviconClient* client,
FaviconDriver* driver,
FaviconHandlerDelegate* delegate,
Type icon_type);
@@ -154,8 +156,6 @@ class FaviconHandler {
chrome::IconType icon_type,
const gfx::Image& image);
- virtual FaviconService* GetFaviconService();
-
// Returns true if the favicon should be saved.
virtual bool ShouldSaveFavicon(const GURL& url);
@@ -288,6 +288,9 @@ class FaviconHandler {
// The Profile associated with this handler.
Profile* profile_;
+ // The client which implements embedder-specific Favicon operations.
+ FaviconClient* client_; // weak
+
// The driver which implements platform-specific Favicon operations.
FaviconDriver* driver_; // weak
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_tab_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698