Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: third_party/WebKit/Source/web/EditorClientImpl.cpp

Issue 2287803002: Add support for edit commands in OOPIFs. (Closed)
Patch Set: Cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/EditorClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/EditorClientImpl.cpp b/third_party/WebKit/Source/web/EditorClientImpl.cpp
index 80b7a2ff31cf2caf14f968f9cdc1fbb6aeb2383a..c93fc041af232fcfaa70e4553494b093caa8e1e2 100644
--- a/third_party/WebKit/Source/web/EditorClientImpl.cpp
+++ b/third_party/WebKit/Source/web/EditorClientImpl.cpp
@@ -73,9 +73,10 @@ bool EditorClientImpl::canPaste(LocalFrame* frame, bool defaultValue) const
return webFrame->contentSettingsClient()->allowReadFromClipboard(defaultValue);
}
-bool EditorClientImpl::handleKeyboardEvent()
+bool EditorClientImpl::handleKeyboardEvent(LocalFrame* frame)
{
- return m_webView->client() && m_webView->client()->handleCurrentKeyboardEvent();
+ WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(frame);
+ return webFrame->client() && webFrame->client()->handleCurrentKeyboardEvent();
lfg 2016/09/02 17:20:02 I think the WebLocalFrame client is always non-nul
alexmos 2016/09/07 00:03:00 I thought it can be null in blink unit tests. The
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/EditorClientImpl.h ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698