Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/renderer/render_widget.cc

Issue 2287803002: Add support for edit commands in OOPIFs. (Closed)
Patch Set: Remove WebFrameClient null checks Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget.h ('k') | content/renderer/render_widget_owner_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index d5b61b7d027a975a9efd26d9f9711c0a13186430..b51dd3af914c7c4a27b6fa06088f37fbeed72251 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -487,6 +487,8 @@ bool RenderWidget::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(InputMsg_ImeSetComposition, OnImeSetComposition)
IPC_MESSAGE_HANDLER(InputMsg_ImeConfirmComposition, OnImeConfirmComposition)
IPC_MESSAGE_HANDLER(InputMsg_MouseCaptureLost, OnMouseCaptureLost)
+ IPC_MESSAGE_HANDLER(InputMsg_SetEditCommandsForNextKeyEvent,
+ OnSetEditCommandsForNextKeyEvent)
IPC_MESSAGE_HANDLER(InputMsg_SetFocus, OnSetFocus)
IPC_MESSAGE_HANDLER(InputMsg_SyntheticGestureCompleted,
OnSyntheticGestureCompleted)
@@ -696,6 +698,11 @@ void RenderWidget::OnMouseCaptureLost() {
webwidget_->mouseCaptureLost();
}
+void RenderWidget::OnSetEditCommandsForNextKeyEvent(
+ const EditCommands& edit_commands) {
+ edit_commands_ = edit_commands;
+}
+
void RenderWidget::OnSetFocus(bool enable) {
has_focus_ = enable;
@@ -888,8 +895,17 @@ void RenderWidget::ObserveGestureEventAndResult(
}
void RenderWidget::OnDidHandleKeyEvent() {
- if (owner_delegate_)
- owner_delegate_->RenderWidgetDidHandleKeyEvent();
+ ClearEditCommands();
+}
+
+void RenderWidget::SetEditCommandForNextKeyEvent(const std::string& name,
+ const std::string& value) {
+ ClearEditCommands();
+ edit_commands_.emplace_back(name, value);
+}
+
+void RenderWidget::ClearEditCommands() {
+ edit_commands_.clear();
}
void RenderWidget::OnDidOverscroll(const ui::DidOverscrollParams& params) {
« no previous file with comments | « content/renderer/render_widget.h ('k') | content/renderer/render_widget_owner_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698