Add support for edit commands in OOPIFs.

chrome/browser/site_per_process_interactive_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
+#include "ui/base/ime/text_edit_commands.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "url/gurl.h"
 
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+#include "ui/base/ime/linux/text_edit_command_auralinux.h"
+#include "ui/base/ime/linux/text_edit_key_bindings_delegate_auralinux.h"
+#endif
+
 class SitePerProcessInteractiveBrowserTest : public InProcessBrowserTest {
  public:
   SitePerProcessInteractiveBrowserTest() {}
   ~SitePerProcessInteractiveBrowserTest() override {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     content::IsolateAllSitesForTesting(command_line);
   }
 
   void SetUpOnMainThread() override {
@@ skipping 127 matching lines @@
   SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('O'),
                    ui::DomCode::US_O, ui::VKEY_O, false, false, false, false);
 
   // Verify that the input field in the subframe received the keystrokes.
   EXPECT_TRUE(ExecuteScriptAndExtractString(
       child,
       "window.domAutomationController.send(getInputFieldText());", &result));
   EXPECT_EQ("FOO", result);
 }
 
+// Ensure that a cross-process subframe can utilize keyboard edit commands.
+// See https://crbug.com/640706.  This test is Linux-specific, as it relies on
+// overriding TextEditKeyBindingsDelegateAuraLinux, which only exists on Linux.
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
+                       SubframeKeyboardEditCommands) {

[Charlie Reis, 2016/09/07 20:41:42]

I think this might belong more in site_per_process_text_input_browsertest.cc
(which Ehsan has been using for IME tests)?

No problem leaving it here if that's not an easy move.

[alexmos, 2016/09/08 21:00:07]

Done.  It was straightforward to move. :)

+  GURL main_url(embedded_test_server()->GetURL(
+      "a.com", "/frame_tree/page_with_one_frame.html"));
+  ui_test_utils::NavigateToURL(browser(), main_url);
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+
+  GURL frame_url(
+      embedded_test_server()->GetURL("b.com", "/page_with_input_field.html"));
+  EXPECT_TRUE(NavigateIframeToURL(web_contents, "child0", frame_url));
+
+  // Focus the subframe and then its input field.  The return value
+  // "input-focus" will be sent once the input field's focus event fires.
+  content::RenderFrameHost* child =
+      ChildFrameAt(web_contents->GetMainFrame(), 0);
+  std::string result;
+  EXPECT_TRUE(ExecuteScriptAndExtractString(
+      child, "window.focus(); focusInputField();", &result));
+  EXPECT_EQ("input-focus", result);
+  EXPECT_EQ(child, web_contents->GetFocusedFrame());
+
+  // Generate a couple of keystrokes, which will be routed to the subframe.
+  SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('1'),
+                   ui::DomCode::DIGIT1, ui::VKEY_1, false, false, false, false);
+  SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('2'),
+                   ui::DomCode::DIGIT2, ui::VKEY_2, false, false, false, false);
+
+  // Verify that the input field in the subframe received the keystrokes.
+  EXPECT_TRUE(ExecuteScriptAndExtractString(
+      child, "window.domAutomationController.send(getInputFieldText());",
+      &result));
+  EXPECT_EQ("12", result);
+
+  // Define and install a test delegate that translates any keystroke to a
+  // command to delete all text from current cursor position to the beginning
+  // of the line.
+  class TextDeleteDelegate : public ui::TextEditKeyBindingsDelegateAuraLinux {
+   public:
+    TextDeleteDelegate() {}
+    ~TextDeleteDelegate() override {}
+
+    bool MatchEvent(
+        const ui::Event& event,
+        std::vector<ui::TextEditCommandAuraLinux>* commands) override {
+      if (commands) {
+        commands->emplace_back(ui::TextEditCommand::DELETE_TO_BEGINNING_OF_LINE,
+                               "");
+      }
+      return true;
+    }
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(TextDeleteDelegate);
+  };
+
+  TextDeleteDelegate delegate;
+  ui::TextEditKeyBindingsDelegateAuraLinux* old_delegate =
+      ui::GetTextEditKeyBindingsDelegate();
+  ui::SetTextEditKeyBindingsDelegate(&delegate);
+
+  // Press ctrl-alt-shift-D.  The test's delegate will pretend that this
+  // corresponds to the command to delete everyting to the beginning of the
+  // line.  Note the use of SendKeyPressSync instead of SimulateKeyPress, as
+  // the latter doesn't go through
+  // RenderWidgetHostViewAura::ForwardKeyboardEvent, which contains the edit
+  // commands logic that's's tested here.

[Charlie Reis, 2016/09/07 20:41:42]

nit: that's

[alexmos, 2016/09/08 21:00:07]

Done.

+  ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_D,
+                                              true, true, true, false));
+  ui::SetTextEditKeyBindingsDelegate(old_delegate);
+
+  // Verify that the input field in the subframe is erased.
+  EXPECT_TRUE(ExecuteScriptAndExtractString(
+      child, "window.domAutomationController.send(getInputFieldText());",
+      &result));
+  EXPECT_EQ("", result);
+}
+#endif
+
 // Ensure that sequential focus navigation (advancing focused elements with
 // <tab> and <shift-tab>) works across cross-process subframes.
 // The test sets up six inputs fields in a page with two cross-process
 // subframes:
 //                 child1            child2
 //             /------------\    /------------\.
 //             | 2. <input> |    | 4. <input> |
 //  1. <input> | 3. <input> |    | 5. <input> |  6. <input>
 //             \------------/    \------------/.
 //
@@ skipping 579 matching lines @@
                                           "document.pointerLockElement)",
                                           &mouse_locked));
   EXPECT_TRUE(mouse_locked);
   EXPECT_TRUE(main_frame->GetView()->IsMouseLocked());
 
   EXPECT_TRUE(ExecuteScript(main_frame,
                             "document.querySelector('iframe').parentNode."
                             "removeChild(document.querySelector('iframe'))"));
   EXPECT_FALSE(main_frame->GetView()->IsMouseLocked());
 }