Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2287793002: Converted Observatory field-view element (Closed)
Patch Set: Fixed tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/repositories/field.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 84709866be36663aac6b1c50e584d12c0cf52509..83dfd1cd9ad16c70e02ad4640147613394fe70ca 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -2979,7 +2979,7 @@ class Sentinel extends ServiceObject implements M.Sentinel {
String toString() => 'Sentinel($kind)';
}
-class Field extends HeapObject implements M.FieldRef {
+class Field extends HeapObject implements M.Field {
// Library or Class.
@observable HeapObject dartOwner;
@observable Library library;
@@ -2992,7 +2992,8 @@ class Field extends HeapObject implements M.FieldRef {
@observable String vmName;
@observable bool guardNullable;
- @observable var /* Class | String */ guardClass;
+ M.GuardClassKind guardClassKind;
+ @observable Class guardClass;
@observable String guardLength;
@observable SourceLocation location;
@@ -3025,7 +3026,21 @@ class Field extends HeapObject implements M.FieldRef {
}
guardNullable = map['_guardNullable'];
- guardClass = map['_guardClass'];
+ if (map['_guardClass'] is Class) {
+ guardClass = map['_guardClass'];
+ guardClassKind = M.GuardClassKind.single;
+ } else {
+ switch (map['_guardClass']) {
+ case 'various':
+ guardClassKind = M.GuardClassKind.dynamic;
+ break;
+ case 'unknown':
+ default:
+ guardClassKind = M.GuardClassKind.unknown;
+ break;
+ }
+ }
+
guardLength = map['_guardLength'];
location = map['location'];
_loaded = true;
« no previous file with comments | « runtime/observatory/lib/src/repositories/field.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698