Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2287793002: Converted Observatory field-view element (Closed)
Patch Set: Fixed tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/class_tree.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 365690773ab36fb3fc8e650230bb2f18b992bff1..6d33a4f97222701cbec67a8de2ddc26cad9d2d05 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -6,7 +6,9 @@ part of app;
AllocationProfileRepository _allocationProfileRepository
= new AllocationProfileRepository();
+ClassRepository _classRepository = new ClassRepository();
ContextRepository _contextRepository = new ContextRepository();
+FieldRepository _fieldRepository = new FieldRepository();
HeapSnapshotRepository _heapSnapshotRepository
= new HeapSnapshotRepository();
ICDataRepository _icdataRepository = new ICDataRepository();
@@ -22,6 +24,7 @@ ObjectStoreRepository _objectstoreRepository
PersistentHandlesRepository _persistentHandlesRepository
= new PersistentHandlesRepository();
PortsRepository _portsRepository = new PortsRepository();
+ScriptRepository _scriptRepository = new ScriptRepository();
class IsolateNotFound implements Exception {
String isolateId;
@@ -204,6 +207,20 @@ class InspectPage extends MatchingPage {
container.children = [
new ErrorViewElement(app.notifications, obj, queue: app.queue)
];
+ } else if (obj is Field) {
+ container.children = [
+ new FieldViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _fieldRepository,
+ _classRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _scriptRepository,
+ _instanceRepository,
+ queue: app.queue)
+ ];
} else if (obj is ICData) {
container.children = [
new ICDataViewElement(app.vm, obj.isolate, obj, app.events,
@@ -256,7 +273,7 @@ class ClassTreePage extends SimplePage {
isolate,
app.events,
app.notifications,
- new ClassRepository(isolate))
+ _classRepository)
];
});
}
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/class_tree.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698