Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2287793002: Converted Observatory field-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -179 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 4 chunks +18 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.dart View 1 chunk +281 lines, -8 lines 0 comments Download
D runtime/observatory/lib/src/elements/field_view.html View 1 chunk +0 lines, -99 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/field.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/class.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/field.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/class.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/field.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 3 chunks +18 lines, -3 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 3 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/class_tree/element_test.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/class.dart View 1 2 chunks +7 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/observatory_ui.status View 1 2 chunks +2 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-27 00:04:04 UTC) #2
rmacnak
lgtm
4 years, 3 months ago (2016-08-29 17:24:56 UTC) #3
cbernaschina
4 years, 3 months ago (2016-08-29 17:46:25 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-29 17:47:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8e7725a8b4dfbf758cbaecb1db05ce4b73dcaf41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698