Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2287783003: Revert of Always deserialize scope infos for parsing (Closed)

Created:
4 years, 3 months ago by Toon Verwaest
Modified:
4 years, 3 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Always deserialize scope infos for parsing (patchset #3 id:40001 of https://codereview.chromium.org/2280933002/ ) Reason for revert: Significantly tanks parsing. We probably should just keep on doing what we're doing: partially deserialize while resolving variables. If we do scope-info backed resolution after regular resolution based on remaining free variables, we can probably reduce the time-frame of that part. We soon after anyway need to sync with the main thread. Original issue's description: > Always deserialize scope infos for parsing > > When looking up variables in the ScopeInfo, we did a linear scan of the > ScopeInfo. Since that's unacceptably slow, a context slot cache was added > that would speed up repeated lookups of the same variable. > > Instead, just always fully convert the ScopeInfo into scopes, so they can > lookup variables without scanning the ScopeInfo. > > This also allows for removing the now unused ContextSlotCache. > > R=adamk@chromium.org,verwaest@chromium.org,marja@chromium.org > BUG=v8:5315 > > Committed: https://crrev.com/81f824cad18e4dc873a8838943217eb9c9f0c1f0 > Cr-Commit-Position: refs/heads/master@{#38953} TBR=adamk@chromium.org,marja@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5315 Committed: https://crrev.com/f046cb95439ca501bae8dc5eed0dbefa87d7f148 Cr-Commit-Position: refs/heads/master@{#38958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/ast/context-slot-cache.h View 1 chunk +113 lines, -0 lines 0 comments Download
A src/ast/context-slot-cache.cc View 1 chunk +91 lines, -0 lines 0 comments Download
M src/ast/scopeinfo.cc View 3 chunks +17 lines, -1 line 0 comments Download
M src/ast/scopes.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ast/scopes.cc View 4 chunks +71 lines, -8 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/isolate.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
Created Revert of Always deserialize scope infos for parsing
4 years, 3 months ago (2016-08-27 07:08:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287783003/1
4 years, 3 months ago (2016-08-27 07:08:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 07:08:34 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 07:09:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f046cb95439ca501bae8dc5eed0dbefa87d7f148
Cr-Commit-Position: refs/heads/master@{#38958}

Powered by Google App Engine
This is Rietveld 408576698