Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2287773002: Revert of exo: Disable RGBX fullscreen overlays. (Closed)

Created:
4 years, 3 months ago by Daniele Castagna
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of exo: Disable RGBX fullscreen overlays. (patchset #1 id:1 of https://codereview.chromium.org/2278803003/ ) Reason for revert: crrev.com/2281033003 makes it so the compositor sends only one plane to Ozone. In this way Ozone will accept an RGBX fullscreen plane. Original issue's description: > exo: Disable RGBX fullscreen overlays. > > Fullscreen overlays have been enabled on minnie. > Unfortunately there are some issues in HardwareDisplayPlaneManager:: > AssignOverlayPlanes with RGBX buffers. > > This patch disables the overlay optimization for those buffers > while we work on a fix. > > BUG=b/29430506 > > Committed: https://crrev.com/18d1778af83ec9877cdf33401eddf4b082f766ef > Cr-Commit-Position: refs/heads/master@{#414281} TBR=reveman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=b/29430506 Committed: https://crrev.com/15f606fd19cdecf925c81936fae6abb0dda1f553 Cr-Commit-Position: refs/heads/master@{#414853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/exo/display.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Daniele Castagna
Created Revert of exo: Disable RGBX fullscreen overlays.
4 years, 3 months ago (2016-08-26 22:23:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287773002/1
4 years, 3 months ago (2016-08-26 22:24:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 23:14:35 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:16:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15f606fd19cdecf925c81936fae6abb0dda1f553
Cr-Commit-Position: refs/heads/master@{#414853}

Powered by Google App Engine
This is Rietveld 408576698