Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/bookmarks/browser/bookmark_codec.h

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_codec.h
diff --git a/components/bookmarks/browser/bookmark_codec.h b/components/bookmarks/browser/bookmark_codec.h
index 8b42d3940bbb12bc3475b42564d0021721c87440..7760826e4f61d7769fe907a2b9f639f5e953e211 100644
--- a/components/bookmarks/browser/bookmark_codec.h
+++ b/components/bookmarks/browser/bookmark_codec.h
@@ -6,6 +6,8 @@
#define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
#include <stdint.h>
+
+#include <memory>
#include <set>
#include <string>
@@ -108,8 +110,7 @@ class BookmarkCodec {
private:
// Encodes node and all its children into a Value object and returns it.
- // The caller takes ownership of the returned object.
- base::Value* EncodeNode(const BookmarkNode* node);
+ std::unique_ptr<base::Value> EncodeNode(const BookmarkNode* node);
// Encodes the given meta info into a Value object and returns it. The caller
// takes ownership of the returned object.
« no previous file with comments | « no previous file | components/bookmarks/browser/bookmark_codec.cc » ('j') | components/bookmarks/browser/bookmark_codec.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698