Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: components/domain_reliability/scheduler.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/scheduler.cc
diff --git a/components/domain_reliability/scheduler.cc b/components/domain_reliability/scheduler.cc
index 87a908103927e87d1812b88501f53fcd05e1ed6a..20bd3347a0863af67116b0c96566edcad1863d0e 100644
--- a/components/domain_reliability/scheduler.cc
+++ b/components/domain_reliability/scheduler.cc
@@ -189,7 +189,6 @@ std::unique_ptr<base::Value> DomainReliabilityScheduler::GetWebUIData() const {
value->SetInteger("failures", collector->failure_count());
value->SetInteger("next_upload",
(collector->GetReleaseTime() - now).InSeconds());
- // Using release instead of Pass because Pass can't implicitly upcast.
danakj 2016/08/26 22:59:24 :D
collectors_value->Append(std::move(value));
}
data->Set("collectors", std::move(collectors_value));

Powered by Google App Engine
This is Rietveld 408576698