Switch //components away from base::ListValue::Append(Value*) overload.

components/flags_ui/flags_state.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/flags_ui/flags_state.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/callback.h"
@@ skipping 469 matching lines @@
   std::set<std::string> enabled_entries;
   GetSanitizedEnabledFlags(flags_storage, &enabled_entries);
 
   int current_platform = GetCurrentPlatform();
 
   for (size_t i = 0; i < num_feature_entries_; ++i) {
     const FeatureEntry& entry = feature_entries_[i];
     if (skip_feature_entry.Run(entry))
       continue;
 
-    base::DictionaryValue* data = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> data(new base::DictionaryValue());
     data->SetString("internal_name", entry.internal_name);
     data->SetString("name", l10n_util::GetStringUTF16(entry.visible_name_id));
     data->SetString("description",
                     l10n_util::GetStringUTF16(entry.visible_description_id));
 
     base::ListValue* supported_platforms = new base::ListValue();
     AddOsStrings(entry.supported_platforms, supported_platforms);
     data->Set("supported_platforms", supported_platforms);
     // True if the switch is not currently passed.
     bool is_default_value = IsDefaultValue(entry, enabled_entries);
@@ skipping 21 matching lines @@
     if (access == kOwnerAccessToFlags &&
         (entry.supported_platforms & kOsCrOSOwnerOnly) != 0) {
       supported = true;
     }
 #endif
 #if defined(OS_IOS)
     if (access == kAppleReviewAccessToFlags)
       supported = ((entry.supported_platforms & kOsIosAppleReview) != 0);
 #endif
     if (supported)
-      supported_entries->Append(data);
+      supported_entries->Append(std::move(data));
     else
-      unsupported_entries->Append(data);
+      unsupported_entries->Append(std::move(data));
   }
 }
 
 // static
 int FlagsState::GetCurrentPlatform() {
 #if defined(OS_IOS)  // Needs to be before the OS_MACOSX check.
   return kOsIos;
 #elif defined(OS_MACOSX)
   return kOsMac;
 #elif defined(OS_WIN)
@@ skipping 181 matching lines @@
   }
 
   std::set<std::string> new_enabled_entries =
       base::STLSetIntersection<std::set<std::string>>(platform_entries,
                                                       *result);
 
   result->swap(new_enabled_entries);
 }
 
 }  // namespace flags_ui