Switch //components away from base::ListValue::Append(Value*) overload.

components/error_page/common/localized_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/error_page/common/localized_error.h"
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "components/error_page/common/error_page_params.h"
 #include "components/error_page/common/error_page_switches.h"
 #include "components/error_page/common/net_error_info.h"
@@ skipping 472 matching lines @@
     }
   }
 }
 
 // Helper function that creates a single entry dictionary and adds it
 // to a ListValue,
 void AddSingleEntryDictionaryToList(base::ListValue* list,
                                     const char* path,
                                     int message_id,
                                     bool insert_as_first_item) {
-  base::DictionaryValue* suggestion_list_item = new base::DictionaryValue;
+  std::unique_ptr<base::DictionaryValue> suggestion_list_item(
+      new base::DictionaryValue);
   suggestion_list_item->SetString(path, l10n_util::GetStringUTF16(message_id));
 
   if (insert_as_first_item) {
-    list->Insert(0, suggestion_list_item);
+    list->Insert(0, suggestion_list_item.release());

[blundell, 2016/08/29 07:39:15]

I assume that this is targeted for followup?

[dcheng, 2016/08/30 17:41:55]

Yes, there's no equivalent for Insert() atm.

   } else {
-    list->Append(suggestion_list_item);
+    list->Append(std::move(suggestion_list_item));
   }
 }
 
 // Adds a linked suggestion dictionary entry to the suggestions list.
 void AddLinkedSuggestionToList(const int error_code,
                                const std::string& locale,
                                base::ListValue* suggestions_summary_list,
                                bool standalone_suggestion) {
   GURL learn_more_url;
   base::string16 suggestion_string = standalone_suggestion ?
@@ skipping 197 matching lines @@
   }
 
   if (header_message_id) {
     suggestion_list_item->SetString("header",
         l10n_util::GetStringUTF16(header_message_id));
   }
   if (body_message_id) {
     suggestion_list_item->SetString("body",
         l10n_util::GetStringUTF16(body_message_id));
   }
-  list->Append(suggestion_list_item);
+  list->Append(base::WrapUnique(suggestion_list_item));
   return suggestion_list_item;
 }
 
 // Certain suggestions have supporting details which get displayed under
 // the "Details" button.
 void AddSuggestionsDetails(int error_code,
                            base::DictionaryValue* error_strings,
                            int suggestions,
                            base::ListValue* suggestions_details) {
   if (suggestions & SUGGEST_CHECK_CONNECTION) {
@@ skipping 274 matching lines @@
 
 bool LocalizedError::HasStrings(const std::string& error_domain,
                                 int error_code) {
   // Whether or not the there are strings for an error does not depend on
   // whether or not the page was be generated by a POST, so just claim it was
   // not.
   return LookupErrorMap(error_domain, error_code, /*is_post=*/false) != nullptr;
 }
 
 }  // namespace error_page