Switch //components away from base::ListValue::Append(Value*) overload.

components/cloud_devices/common/description_items_inl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CLOUD_DEVICES_COMMON_DESCRIPTION_DESCRIPTION_ITEMS_INL_H_
 #define COMPONENTS_CLOUD_DEVICES_COMMON_DESCRIPTION_DESCRIPTION_ITEMS_INL_H_
 
 #include <stddef.h>
 
+#include <memory>
+#include <utility>
 #include <vector>
 
 #include "base/numerics/safe_conversions.h"
 #include "components/cloud_devices/common/description_items.h"
 
 // Implementation of templates defined in header file.
 // This file should be included from CC file with implementation of device
 // specific capabilities.
 
 namespace cloud_devices {
@@ skipping 38 matching lines @@
   return IsValid();
 }
 
 template <class Option, class Traits>
 void ListCapability<Option, Traits>::SaveTo(
     CloudDeviceDescription* description) const {
   DCHECK(IsValid());
   base::ListValue* options_list =
       description->CreateListItem(Traits::GetCapabilityPath());
   for (size_t i = 0; i < options_.size(); ++i) {
-    base::DictionaryValue* option_value = new base::DictionaryValue;
-    options_list->Append(option_value);
-    Traits::Save(options_[i], option_value);
+    std::unique_ptr<base::DictionaryValue> option_value(
+        new base::DictionaryValue);
+    Traits::Save(options_[i], option_value.get());
+    options_list->Append(std::move(option_value));

[blundell, 2016/08/29 07:39:15]

similar question for my own understanding: is the std::move call here necessary?

[dcheng, 2016/08/30 17:41:55]

It is: one way to think of it is move constructors / assignment operators can
only be called on unnamed objects (in other words, temporaries). In that sense,
std::move() is a 'name eraser'. The internal C++ totws are a pretty good
explainer (see #55 and #77)

   }
 }
 
 template <class Option, class Traits>
 SelectionCapability<Option, Traits>::SelectionCapability() {
   Reset();
 }
 
 template <class Option, class Traits>
 SelectionCapability<Option, Traits>::~SelectionCapability() {
@@ skipping 39 matching lines @@
 }
 
 template <class Option, class Traits>
 void SelectionCapability<Option, Traits>::SaveTo(
     CloudDeviceDescription* description) const {
   DCHECK(IsValid());
   base::ListValue* options_list = new base::ListValue;
   description->CreateItem(Traits::GetCapabilityPath())
       ->Set(json::kKeyOption, options_list);
   for (size_t i = 0; i < options_.size(); ++i) {
-    base::DictionaryValue* option_value = new base::DictionaryValue;
-    options_list->Append(option_value);
+    std::unique_ptr<base::DictionaryValue> option_value(
+        new base::DictionaryValue);
     if (base::checked_cast<int>(i) == default_idx_)
       option_value->SetBoolean(json::kKeyIsDefault, true);
-    Traits::Save(options_[i], option_value);
+    Traits::Save(options_[i], option_value.get());
+    options_list->Append(std::move(option_value));
   }
 }
 
 template <class Traits>
 BooleanCapability<Traits>::BooleanCapability() {
   Reset();
 }
 
 template <class Traits>
 BooleanCapability<Traits>::~BooleanCapability() {
@@ skipping 101 matching lines @@
 template <class Option, class Traits>
 void TicketItem<Option, Traits>::SaveTo(
     CloudDeviceDescription* description) const {
   DCHECK(IsValid());
   Traits::Save(value(), description->CreateItem(Traits::GetTicketItemPath()));
 }
 
 }  // namespace cloud_devices
 
 #endif  // COMPONENTS_CLOUD_DEVICES_COMMON_DESCRIPTION_DESCRIPTION_ITEMS_INL_H_