Switch //components away from base::ListValue::Append(Value*) overload.

components/signin/core/browser/about_signin_internals.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/about_signin_internals.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 411 matching lines @@
     if (a->consumer_id == b->consumer_id) {
       return a->scopes < b->scopes;
     }
     return a->consumer_id < b->consumer_id;
   }
   return a->request_time < b->request_time;
 }
 
 void AboutSigninInternals::TokenInfo::Invalidate() { removed_ = true; }
 
-base::DictionaryValue* AboutSigninInternals::TokenInfo::ToValue() const {
+std::unique_ptr<base::DictionaryValue>
+AboutSigninInternals::TokenInfo::ToValue() const {
   std::unique_ptr<base::DictionaryValue> token_info(
       new base::DictionaryValue());
   token_info->SetString("service", consumer_id);
 
   std::string scopes_str;
   for (OAuth2TokenService::ScopeSet::const_iterator it = scopes.begin();
        it != scopes.end();
        ++it) {
     scopes_str += *it + "<br/>";
   }
@@ skipping 21 matching lines @@
       token_info->SetString("status", status_str);
     } else {
       token_info->SetString(
           "status",
           base::StringPrintf("Failure: %s", error.ToString().c_str()));
     }
   } else {
     token_info->SetString("status", "Waiting for response");
   }
 
-  return token_info.release();
+  return token_info;
 }
 
 AboutSigninInternals::SigninStatus::SigninStatus()
     : timed_signin_fields(TIMED_FIELDS_COUNT) {}
 
 AboutSigninInternals::SigninStatus::~SigninStatus() {
   for (TokenInfoMap::iterator it = token_info_map.begin();
        it != token_info_map.end();
        ++it) {
     base::STLDeleteElements(&it->second);
@@ skipping 161 matching lines @@
     std::sort(it->second.begin(), it->second.end(), TokenInfo::LessThan);
     const std::vector<TokenInfo*>& tokens = it->second;
 
     // TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460
     // is fixed.
     tracked_objects::ScopedTracker tracking_profile43(
         FROM_HERE_WITH_EXPLICIT_FUNCTION(
             "422460 AboutSigninInternals::SigninStatus::ToValue43"));
 
     for (size_t i = 0; i < tokens.size(); ++i) {
-      base::DictionaryValue* token_info = tokens[i]->ToValue();
-      token_details->Append(token_info);
+      token_details->Append(tokens[i]->ToValue());
     }
   }
 
   base::ListValue* account_info = new base::ListValue();
   signin_status->Set("accountInfo", account_info);
   const std::vector<std::string>& accounts_in_token_service =
       token_service->GetAccounts();
 
   if(accounts_in_token_service.size() == 0) {
     std::unique_ptr<base::DictionaryValue> no_token_entry(
         new base::DictionaryValue());
     no_token_entry->SetString("accountId", "No token in Token Service.");
     account_info->Append(std::move(no_token_entry));
   }
 
   for(const std::string& account_id : accounts_in_token_service) {
     std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
     entry->SetString("accountId", account_id);
     account_info->Append(std::move(entry));
   }
 
   return signin_status;
 }