Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2287713002: DevTools: remove UISourceCodeFrame from context when switching panels. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove UISourceCodeFrame from context when switching panels. BUG=640375 Committed: https://crrev.com/0cfac8a68fbabad4515c0a9f58c9e1dffd8c4a74 Cr-Commit-Position: refs/heads/master@{#415105}

Patch Set 1 #

Patch Set 2 : follow-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 2 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Context.js View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
pfeldman
4 years, 3 months ago (2016-08-26 21:19:54 UTC) #2
alph
lgtm
4 years, 3 months ago (2016-08-26 21:23:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287713002/1
4 years, 3 months ago (2016-08-26 21:24:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/285828)
4 years, 3 months ago (2016-08-26 23:35:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287713002/20001
4 years, 3 months ago (2016-08-29 22:59:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 04:39:47 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0cfac8a68fbabad4515c0a9f58c9e1dffd8c4a74 Cr-Commit-Position: refs/heads/master@{#415105}
4 years, 3 months ago (2016-08-30 04:41:34 UTC) #13
pfeldman
4 years, 3 months ago (2016-09-06 18:05:31 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2311303002/ by pfeldman@chromium.org.

The reason for reverting is: I'll have a better one for merge..

Powered by Google App Engine
This is Rietveld 408576698