Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 22877043: MIPS: Add a trap_on_abort flag. (Closed)

Created:
7 years, 3 months ago by kilvadyb
Modified:
7 years, 3 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Add a trap_on_abort flag. Port r16319 (22e0380) Original commit message: By setting this flag assertions behind --debug-code will trigger a breakpoint instead of a call into Abort. This eases debugging, as the call site is less cluttered and the backtrace starts where it should. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 3 months ago (2013-08-26 13:13:51 UTC) #1
Benedikt Meurer
LGTM
7 years, 3 months ago (2013-08-26 13:23:39 UTC) #2
palfia
7 years, 3 months ago (2013-08-26 20:30:22 UTC) #3
Committed as r16342.

Powered by Google App Engine
This is Rietveld 408576698