Source/core/rendering/svg/SVGPathData.cpp - Issue 22877029: Introduce toSVGEllipseElement(), and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGPathData.cpp

Issue 22877029: Introduce toSVGEllipseElement(), and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGPathData.cpp

diff --git a/Source/core/rendering/svg/SVGPathData.cpp b/Source/core/rendering/svg/SVGPathData.cpp

index 707f5488a8732c70ec861d1830f6c1d13e4cc878..60305024a2ab1db200b9c91abb9c774322cb2c09 100644

--- a/Source/core/rendering/svg/SVGPathData.cpp

+++ b/Source/core/rendering/svg/SVGPathData.cpp

@@ -47,8 +47,7 @@ static void updatePathFromCircleElement(SVGElement* element, Path& path)

static void updatePathFromEllipseElement(SVGElement* element, Path& path)

{

- ASSERT(element->hasTagName(SVGNames::ellipseTag));

- SVGEllipseElement* ellipse = static_cast<SVGEllipseElement*>(element);

+ SVGEllipseElement* ellipse = toSVGEllipseElement(element);

SVGLengthContext lengthContext(element);

float rx = ellipse->rxCurrentValue().value(lengthContext);