Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: pkg/docgen/lib/dart2yaml.dart

Issue 22877022: Fixed parameters losing their original order (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/docgen/lib/dart2yaml.dart
diff --git a/pkg/docgen/lib/dart2yaml.dart b/pkg/docgen/lib/dart2yaml.dart
index 57ca7fe3938605f55a8dfac4efe5199699e4e91f..cbd28ac7d2079535d8862ae1acc49441cd62602f 100644
--- a/pkg/docgen/lib/dart2yaml.dart
+++ b/pkg/docgen/lib/dart2yaml.dart
@@ -26,10 +26,11 @@ String getYamlString(Map documentData) {
*/
void _addLevel(StringBuffer yaml, Map documentData, int level,
{bool isList: false}) {
- // Since the ordering of the keys could be non-deterministic, the keys
- // are sorted to ensure consistency in the output.
+ // TODO(tmandel): The order of the keys could be nondeterministic, but it
+ // is insufficient to just sort the keys, as their order could be significant
+ // (i.e. parameters to a method). This should have a check that the map's key
+ // order is deterministic or something similar.
Jennifer Messerly 2013/08/16 21:43:32 maybe check that documentData is LinkedHashMap or
Tate Mandel 2013/08/16 21:53:41 Are these the only two that are ordered consistent
Jennifer Messerly 2013/08/16 22:05:49 hmm, it's tricky. I guess it depends on who calls
Tate Mandel 2013/08/16 22:09:45 I'd say it should be enforced elsewhere. We probab
var keys = documentData.keys.toList();
- keys.sort();
keys.forEach((key) {
_calcSpaces(level, yaml);
// Only the first entry of the map should be preceeded with a '-' since
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698