Issue 22877020: Make BMP decoder not depend on call to getLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22877020: Make BMP decoder not depend on call to getLength. (Closed)

Created:
7 years, 4 months ago by scroggo

Modified:
7 years, 4 months ago

Reviewers:
bungeman, bungeman-skia, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make BMP decoder not depend on call to getLength. If the decoder does not have a length, use an SkDynamicMemoryStream to copy it to contiguous memory, to be passed to BmpDecoderHelper. BUG=https://b.corp.google.com/issue?id=8432093 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10849

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
	M	src/images/SkImageDecoder_libbmp.cpp	View		1 chunk	+28 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

7 years, 4 months ago (2013-08-21 14:59:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r10849 (presubmit successful).

Expand Messages | Collapse Messages