Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: base/base.gypi

Issue 22877016: Android WebView: don't define sincos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/os_compat_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gypi
diff --git a/base/base.gypi b/base/base.gypi
index 6d82ee335b9fe83eff87f5a9beeaeaf694097c48..ed3dd17296f7d42c3a92b7d4b1348ccf535c8699 100644
--- a/base/base.gypi
+++ b/base/base.gypi
@@ -757,6 +757,13 @@
['include', '^threading/platform_thread_linux\\.cc$'],
],
}],
+ ['OS == "android" and android_webview_build==1', {
+ 'defines': [
+ # WebView builds as part of the system which already has sincos;
brettw 2013/08/16 19:50:05 It sucks to have to define this thing as part of t
Torne 2013/08/19 10:25:49 I intentionally haven't provided a global define f
+ # avoid defining it again as it causes a linker warning.
+ 'ANDROID_SINCOS_PROVIDED',
+ ],
+ }],
['OS == "ios" and _toolset != "host"', {
'sources/': [
# Pull in specific Mac files for iOS (which have been filtered out
« no previous file with comments | « no previous file | base/os_compat_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698