Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: pkg/intl/lib/src/http_request_data_reader.dart

Issue 22877005: Workaround for bug 11834 with Chrome XHR (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/src/http_request_data_reader.dart
diff --git a/pkg/intl/lib/src/http_request_data_reader.dart b/pkg/intl/lib/src/http_request_data_reader.dart
index 530dce6d2553e30ae5d8ddd53dd4c1ba7f7fdb8d..75af61dfdb4ca573d1baded9d784eeecbd67a442 100644
--- a/pkg/intl/lib/src/http_request_data_reader.dart
+++ b/pkg/intl/lib/src/http_request_data_reader.dart
@@ -19,5 +19,10 @@ class HTTPRequestDataReader implements LocaleDataReader {
String url;
HTTPRequestDataReader(this.url);
- Future read(String locale) => HttpRequest.getString('$url$locale.json');
+ Future read(String locale) {
+ // TODO(alanknight): Remove this once it's not necessary for Chrome.
Emily Fortuna 2013/08/12 20:11:52 Can this include the issue number in the comment?
Alan Knight 2013/08/12 20:31:51 Argh. I did that, but I must have gotten the criti
+ // Without it, the tests will be flaky on Chrome.
+ var someNumber = new DateTime.now().millisecondsSinceEpoch;
+ return HttpRequest.getString('$url$locale.json?cacheBlocker=$someNumber');
+ }
}
« no previous file with comments | « no previous file | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698