Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 228763007: Revert of Improve computation of PrefHashCalculator::legacy_device_id_instance_. (Closed)

Created:
6 years, 8 months ago by gab
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Mike Lerman, noms (inactive), robertshield
Visibility:
Public.

Description

Revert of Improve computation of PrefHashCalculator::legacy_device_id_instance_. (https://codereview.chromium.org/231673002/) Reason for revert: PrefHashCalculatorTest.TestLegacyDeviceIdAlgorithm is failing in some configurations. Original issue's description: > Improve computation of PrefHashCalculator::legacy_device_id_instance_. > > 1) Compute it at most once in the lifetime of the browser (rather than at most once per PrefHashCalculator). > > 2) Explicitly AllowIO in the scope of this computation. This isn't ideal, but there is no other good way until we can get rid of this legacy artifact in a few milestones. > > Note that I have to skip a presubmit error for (2): "Banned functions were used. New code should not use ScopedAllowIO." :(. > > BUG=361687 > R=erikwright@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262995 TBR=erikwright@chromium.org NOTREECHECKS=true NOTRY=true BUG=361687 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M chrome/browser/prefs/pref_hash_calculator.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/prefs/pref_hash_calculator.cc View 3 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gab
Created Revert of Improve computation of PrefHashCalculator::legacy_device_id_instance_.
6 years, 8 months ago (2014-04-10 18:02:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/228763007/1
6 years, 8 months ago (2014-04-10 18:02:11 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 18:03:27 UTC) #3
Message was sent while issue was closed.
Change committed as 263028

Powered by Google App Engine
This is Rietveld 408576698