Make sure binutils values are always defined.

Make sure binutils values are always defined.

BUG=352046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262981

[mithro-old, 2014-04-10 09:11:52]

Should fix;
  gyp: name 'binutils_version' is not defined while evaluating condition
'binutils_version>=224' in
/mnt/data/b/build/slave/ASan_Release__32-bit_x86_with_V8-ARM__symbolized_/build/src/build/all.gyp

Tim

[Alexander Potapenko, 2014-04-10 09:20:41]

On 2014/04/10 09:11:52, mithro wrote:
> Should fix;
>   gyp: name 'binutils_version' is not defined while evaluating condition
> 'binutils_version>=224' in
>
/mnt/data/b/build/slave/ASan_Release__32-bit_x86_with_V8-ARM__symbolized_/build/src/build/all.gyp
> 
> Tim

Seems to work. LGTM

[mithro-old, 2014-04-10 09:22:28]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2014-04-10 09:22:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/228763006/1

[mithro-old, 2014-04-10 09:35:30]

The CQ bit was unchecked by mithro@mithis.com

[mithro-old, 2014-04-10 09:39:00]

On 2014/04/10 09:20:41, Alexander Potapenko wrote:
> On 2014/04/10 09:11:52, mithro wrote:
> > Should fix;
> >   gyp: name 'binutils_version' is not defined while evaluating condition
> > 'binutils_version>=224' in
> >
>
/mnt/data/b/build/slave/ASan_Release__32-bit_x86_with_V8-ARM__symbolized_/build/src/build/all.gyp
> > 
> > Tim
> 
> Seems to work. LGTM

Can you try the updated patch?

[Alexander Potapenko, 2014-04-10 09:46:58]

On 2014/04/10 09:39:00, mithro wrote:
> On 2014/04/10 09:20:41, Alexander Potapenko wrote:
> > On 2014/04/10 09:11:52, mithro wrote:
> > > Should fix;
> > >   gyp: name 'binutils_version' is not defined while evaluating condition
> > > 'binutils_version>=224' in
> > >
> >
>
/mnt/data/b/build/slave/ASan_Release__32-bit_x86_with_V8-ARM__symbolized_/build/src/build/all.gyp
> > > 
> > > Tim
> > 
> > Seems to work. LGTM
> 
> Can you try the updated patch?

Works as well. LGTM

[Alexander Potapenko, 2014-04-10 09:50:23]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-04-10 09:50:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/228763006/20001

[commit-bot: I haz the power, 2014-04-10 10:19:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 10:19:54]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg

[mithro-old, 2014-04-10 10:46:12]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2014-04-10 10:46:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/228763006/20001

[commit-bot: I haz the power, 2014-04-10 14:02:08]

Change committed as 262981