Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 228763003: Interceptor test for the mojo spy. (Closed)

Created:
6 years, 8 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 8 months ago
Reviewers:
DaveMoore, viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Interceptor test for the mojo spy. Makes sure the interceptor is called with reasonable parameters. more context on this CL https://codereview.chromium.org/225203002/ BUG=360188 TEST=indeed it is a test R=DaveMoore Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263337

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M mojo/service_manager/service_manager_unittest.cc View 1 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
cpu_(ooo_6.6-7.5)
please take a look.
6 years, 8 months ago (2014-04-08 20:21:50 UTC) #1
viettrungluu
https://codereview.chromium.org/228763003/diff/1/mojo/service_manager/service_manager_unittest.cc File mojo/service_manager/service_manager_unittest.cc (right): https://codereview.chromium.org/228763003/diff/1/mojo/service_manager/service_manager_unittest.cc#newcode167 mojo/service_manager/service_manager_unittest.cc:167: int count_; -> call_count_, since your accessor is called ...
6 years, 8 months ago (2014-04-11 00:23:49 UTC) #2
viettrungluu
(lgtm w/changes)
6 years, 8 months ago (2014-04-11 00:24:46 UTC) #3
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 8 months ago (2014-04-11 02:57:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/228763003/20001
6 years, 8 months ago (2014-04-11 02:58:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 04:18:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-11 04:18:33 UTC) #7
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-11 15:36:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/228763003/20001
6 years, 8 months ago (2014-04-11 15:37:23 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 17:17:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-11 17:17:25 UTC) #11
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 8 months ago (2014-04-11 19:20:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/228763003/20001
6 years, 8 months ago (2014-04-11 19:21:15 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 20:34:11 UTC) #14
Message was sent while issue was closed.
Change committed as 263337

Powered by Google App Engine
This is Rietveld 408576698