Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2287603004: Log exceptions in vmservice post() (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Log exceptions in vmservice post() Fixes=https://github.com/dart-lang/sdk/issues/27172 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7bdb33a76692e7ae4c181325a1e40b36123e241c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/bin/vmservice/server.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-26 22:16:34 UTC) #2
rmacnak
lgtm
4 years, 3 months ago (2016-08-26 22:27:14 UTC) #3
cbernaschina
4 years, 3 months ago (2016-08-26 22:36:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bdb33a76692e7ae4c181325a1e40b36123e241c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698