Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 22876029: Revert 219383 "UMA data collector for cross-site documents(XSD)" (Closed)

Created:
7 years, 4 months ago by laforge
Modified:
7 years, 4 months ago
Reviewers:
dsjang
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 219383 "UMA data collector for cross-site documents(XSD)" > UMA data collector for cross-site documents(XSD) > > Intercept cross-site documents and apply a couple of blocking filters to measure how our cross-site document blocking policy affects the renderer behavior. This doesn't actually block anything, but just records UMA data about how these filters work. It does three things: 1) whitelists legitimate XSDs (responses with whitelisted mime types or with valid CORS headers) 2) applies an appropriate content sniffing algorithm depending on the mime type of the response, 3) if it is sniffed as a blocked document, reports its status code and the context (img, script, etc) where the request is originally issued to measure the compatibility impact of the blocking. > > BUG=268640 > Related Doc: https://docs.google.com/a/google.com/document/d/1nB3GruRqQmtA7OPZZAhWOsZDvfWpYpKQXE3cxGxTVfs/edit > > Review URL: https://chromiumcodereview.appspot.com/22254005 TBR=dsjang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1180 lines) Patch
content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
content/child/request_extra_data.h View 3 chunks +0 lines, -3 lines 0 comments Download
content/child/request_extra_data.cc View 2 chunks +0 lines, -2 lines 0 comments Download
content/child/resource_dispatcher.h View 3 chunks +0 lines, -7 lines 0 comments Download
content/child/resource_dispatcher.cc View 12 chunks +6 lines, -41 lines 0 comments Download
content/child/resource_dispatcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
content/child/site_isolation_policy.h View 1 chunk +0 lines, -179 lines 0 comments Download
content/child/site_isolation_policy.cc View 1 chunk +0 lines, -561 lines 0 comments Download
content/child/site_isolation_policy_browsertest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
content/child/site_isolation_policy_unittest.cc View 1 chunk +0 lines, -125 lines 0 comments Download
content/content_child.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
content/public/common/content_switches.h View 2 chunks +1 line, -2 lines 0 comments Download
content/public/common/content_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/cross_site_document_request.html View 1 chunk +0 lines, -81 lines 0 comments Download
content/test/data/cross_site_document_request_target.html View 1 chunk +0 lines, -39 lines 0 comments Download
content/test/data/site_isolation/comment_js.html View 1 chunk +0 lines, -2 lines 0 comments Download
content/test/data/site_isolation/comment_valid.html View 1 chunk +0 lines, -2 lines 0 comments Download
content/test/data/site_isolation/html.txt View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/img.html View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/img.json View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/img.txt View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/img.xml View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/js.html View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/js.json View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/js.txt View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/js.xml View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/json.txt View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/valid.html View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/valid.json View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/valid.xml View 1 chunk +0 lines, -1 line 0 comments Download
content/test/data/site_isolation/xml.txt View 1 chunk +0 lines, -1 line 0 comments Download
net/tools/testserver/testserver.py View 1 chunk +0 lines, -1 line 0 comments Download
webkit/child/resource_loader_bridge.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
7 years, 4 months ago (2013-08-24 23:41:48 UTC) #1
laforge
7 years, 4 months ago (2013-08-24 23:41:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r219468.

Powered by Google App Engine
This is Rietveld 408576698