Issue 22876028: Check listFpsRange before dereferencing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22876028: Check listFpsRange before dereferencing it. (Closed)

Created:
7 years, 4 months ago by wjia(left Chromium)

Modified:
7 years, 4 months ago

Reviewers:
qinmin

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Check listFpsRange before dereferencing it. When camera is in bad state, it could return null pointer from parameters.getSupportedPreviewFpsRange(). It's needed to check pointer before dereferencing it to avoid NullPointerException. BUG=267882 R=qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219382

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/base/android/java/src/org/chromium/media/VideoCapture.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

wjia(left Chromium)

7 years, 4 months ago (2013-08-23 23:50:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r219382 (presubmit successful).