Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2287583002: mash: Fix crash when closing system tray menu (Closed)

Created:
4 years, 3 months ago by James Cook
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix crash when closing system tray menu Look up the container for windows based on shell ID, not window type. BUG=641370 TEST=added to ash_unittests and mash_unittests R=sky@chromium.org Committed: https://crrev.com/0de3abb5ea1173f52e3ad20f7760b2cfe260685d Cr-Commit-Position: refs/heads/master@{#414913}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/wm/container_finder.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/container_finder.cc View 1 chunk +5 lines, -4 lines 0 comments Download
A ash/common/wm/container_finder_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M ash/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ash/mus/wm/container_finder_unittest.cc View 1 chunk +31 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
James Cook
sky, please take a look. https://codereview.chromium.org/2287583002/diff/1/ash/mus/wm/container_finder_unittest.cc File ash/mus/wm/container_finder_unittest.cc (right): https://codereview.chromium.org/2287583002/diff/1/ash/mus/wm/container_finder_unittest.cc#newcode15 ash/mus/wm/container_finder_unittest.cc:15: using ContainerFinderTest = mus::WmTestBase; ...
4 years, 3 months ago (2016-08-26 17:49:13 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-08-26 18:03:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287583002/1
4 years, 3 months ago (2016-08-26 18:12:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/282202)
4 years, 3 months ago (2016-08-26 20:07:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287583002/1
4 years, 3 months ago (2016-08-26 23:25:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 10:58:57 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 11:01:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0de3abb5ea1173f52e3ad20f7760b2cfe260685d
Cr-Commit-Position: refs/heads/master@{#414913}

Powered by Google App Engine
This is Rietveld 408576698