samplecode/SampleLitAtlas.cpp - Issue 2287553002: Moved ambient lights out of SkLight's light array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleLitAtlas.cpp

Issue 2287553002: Moved ambient lights out of SkLight's light array (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: made req changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleLitAtlas.cpp

diff --git a/samplecode/SampleLitAtlas.cpp b/samplecode/SampleLitAtlas.cpp

index cb49bf38723721495746bc65e2f0d08ea3e93429..149da98a021fcfcbcc67b171fc52d1c09b7ee631 100644

--- a/samplecode/SampleLitAtlas.cpp

+++ b/samplecode/SampleLitAtlas.cpp

@@ -184,7 +184,7 @@ private:

builder.add(SkLights::Light::MakeDirectional(

SkColor3f::Make(1.0f, 1.0f, 1.0f), fLightDir));

- builder.add(SkLights::Light::MakeAmbient(SkColor3f::Make(0.2f, 0.2f, 0.2f)));

+ builder.setAmbientLightColor(SkColor3f::Make(0.2f, 0.2f, 0.2f));

fLights = builder.finish();

}